Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NPE #2906

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Handle NPE #2906

merged 2 commits into from
Jul 3, 2024

Conversation

thachlp
Copy link
Contributor

@thachlp thachlp commented Jul 1, 2024

Issues: #2596

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun
Copy link
Collaborator

tishun commented Jul 2, 2024

Could you also please provide some unit/integration tests that check for this condition?

@thachlp
Copy link
Contributor Author

thachlp commented Jul 2, 2024

Could you also please provide some unit/integration tests that check for this condition?

@tishun I add the test for my change, please help review it 🙇

@tishun
Copy link
Collaborator

tishun commented Jul 3, 2024

Awesome, appreciate your help with that!

@tishun tishun merged commit e37e3ab into redis:main Jul 3, 2024
5 checks passed
@thachlp thachlp deleted the handle-npe branch July 3, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants